Remove BackwardsTokenizer based parenthesized_range references in ruff_linter#21836
Merged
MichaReiser merged 7 commits intoastral-sh:mainfrom Dec 11, 2025
Conversation
denyszhak
commented
Dec 8, 2025
denyszhak
commented
Dec 8, 2025
...g/snapshots/ruff_linter__rules__flake8_type_checking__tests__quoted-type-alias_TC008.py.snap
Show resolved
Hide resolved
|
denyszhak
force-pushed
the
feat/ruff-linter-to-use-optimized-parenthesized-range
branch
from
6f5bce9 to
e00dd64
Compare
MichaReiser
added
internal
MichaReiser
changed the title
BackwardsTokenizer based paranthesized_range implementation
MichaReiser
reviewed
Dec 8, 2025
AlexWaygood
changed the title
BackwardsTokenizer based paranthesized_range implementationBackwardsTokenizer based parenthesized_range implementation
Contributor
Author
Only 1 place left: |
Member
Let's focus on the linter for now. |
MichaReiser
changed the title
BackwardsTokenizer based parenthesized_range implementationBackwardsTokenizer based parenthesized_range references in ruff_linter
MichaReiser
reviewed
Dec 9, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
This looks good. We mainly need to look into the regression
MichaReiser
reviewed
Dec 11, 2025
crates/ruff_linter/src/rules/flake8_type_checking/rules/type_alias_quotes.rs
Show resolved
Hide resolved
MichaReiser
reviewed
Dec 11, 2025
MichaReiser
approved these changes
Dec 11, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
This is great, thank you.
I'll wait for #21895 to land first as this can otherwise lead to panics
Co-authored-by: Micha Reiser <micha@reiser.io>
dcreager
added a commit
that referenced
this pull request
Dec 11, 2025
* origin/main: (29 commits) Document range suppressions, reorganize suppression docs (#21884) Ignore ruff:isort like ruff:noqa in new suppressions (#21922) [ty] Handle `Definition`s in `SemanticModel::scope` (#21919) [ty] Attach salsa db when running ide tests for easier debugging (#21917) [ty] Don't show hover for expressions with no inferred type (#21924) [ty] avoid unions of generic aliases of the same class in fixpoint (#21909) [ty] Squash false positive logs for failing to find `builtins` as a real module [ty] Uniformly use "not supported" in diagnostics (#21916) [ty] Reduce size of ty-ide snapshots (#21915) [ty] Adjust scope completions to use all reachable symbols [ty] Rename `all_members_of_scope` to `all_end_of_scope_members` [ty] Remove `all_` prefix from some routines on UseDefMap Enable `--document-private-items` for `ruff_python_formatter` (#21903) Remove `BackwardsTokenizer` based `parenthesized_range` references in `ruff_linter` (#21836) [ty] Revert "Do not infer types for invalid binary expressions in annotations" (#21914) Skip over trivia tokens after re-lexing (#21895) [ty] Avoid inferring types for invalid binary expressions in string annotations (#21911) [ty] Improve overload call resolution tracing (#21913) [ty] fix missing heap_size on Salsa query (#21912) [ty] Support implicit type of `cls` in signatures (#21771) ...
dcreager
added a commit
that referenced
this pull request
Dec 11, 2025
* origin/main: (36 commits) [ty] Defer all parameter and return type annotations (#21906) [ty] Fix workspace symbols to return members too (#21926) Document range suppressions, reorganize suppression docs (#21884) Ignore ruff:isort like ruff:noqa in new suppressions (#21922) [ty] Handle `Definition`s in `SemanticModel::scope` (#21919) [ty] Attach salsa db when running ide tests for easier debugging (#21917) [ty] Don't show hover for expressions with no inferred type (#21924) [ty] avoid unions of generic aliases of the same class in fixpoint (#21909) [ty] Squash false positive logs for failing to find `builtins` as a real module [ty] Uniformly use "not supported" in diagnostics (#21916) [ty] Reduce size of ty-ide snapshots (#21915) [ty] Adjust scope completions to use all reachable symbols [ty] Rename `all_members_of_scope` to `all_end_of_scope_members` [ty] Remove `all_` prefix from some routines on UseDefMap Enable `--document-private-items` for `ruff_python_formatter` (#21903) Remove `BackwardsTokenizer` based `parenthesized_range` references in `ruff_linter` (#21836) [ty] Revert "Do not infer types for invalid binary expressions in annotations" (#21914) Skip over trivia tokens after re-lexing (#21895) [ty] Avoid inferring types for invalid binary expressions in string annotations (#21911) [ty] Improve overload call resolution tracing (#21913) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff_linter now uses optimized version of parenthesized_range on already precomputed tokens instead of generating those over again
Closes #21835
Test Plan
Ensured old tests are still successful. If any additional check required please hint the way and I would love to test.